From 69c1afa5dc0075ec164c9cb003bc0d37ffab520a Mon Sep 17 00:00:00 2001 From: Simon Date: Sun, 27 Apr 2025 22:05:41 +0200 Subject: [PATCH] removed done todos --- arch/cga.h | 2 -- arch/serial.h | 4 ---- debug/output.h | 3 +-- device/serialstream.h | 7 ------- device/textstream.h | 1 - object/stringbuffer.h | 1 - 6 files changed, 1 insertion(+), 17 deletions(-) diff --git a/arch/cga.h b/arch/cga.h index bbf3f59..919c472 100644 --- a/arch/cga.h +++ b/arch/cga.h @@ -95,7 +95,6 @@ void setCursor(unsigned abs_x, unsigned abs_y); /*! \brief Retrieve the keyboard hardware cursor position on screen * - * \todo(11) Implement the method using the \ref IOPort * * \param abs_x absolute column of the keyboard hardware cursor * \param abs_y absolute row of the keyboard hardware cursor @@ -118,7 +117,6 @@ void getCursor(unsigned& abs_x, unsigned& abs_y); * \param character Character to be displayed * \param attrib Attribute with color settings * - * \todo(11) Implement the method */ void show(unsigned abs_x, unsigned abs_y, char character, Attribute attrib = Attribute()); diff --git a/arch/serial.h b/arch/serial.h index d2b471b..1975818 100644 --- a/arch/serial.h +++ b/arch/serial.h @@ -161,7 +161,6 @@ class Serial { /*! \brief Read value from register * - * \todo(11) Implement Method * * \param reg Register index * \return The value read from register @@ -170,7 +169,6 @@ class Serial { /*! \brief Write value to register * - * \todo(11) Implement Method * * \param reg Register index * \param out value to be written @@ -188,7 +186,6 @@ class Serial { * parameters used for the serial connection. Default values are `8N1` (8 bit, * no parity bit, one stop bit) with 115200 Baud using COM1. * - * \todo(11) - Implement Constructor */ explicit Serial(ComPort port = COM1, BaudRate baud_rate = BAUD_115200, DataBits data_bits = DATA_8BIT, @@ -196,7 +193,6 @@ class Serial { /*! \brief Write one byte to the serial interface * - * \todo(11) - Implement Method * * \param out Byte to be written * \return Byte written (or `-1` if writing byte failed) diff --git a/debug/output.h b/debug/output.h index 4dc7530..230a603 100644 --- a/debug/output.h +++ b/debug/output.h @@ -72,7 +72,6 @@ * without any overlap and should be able to display at least 3 lines. * In \MPStuBS, two windows can be placed side-by-side, having 40 columns each. * - * \todo(11) Define `dout` */ extern TextStream dout[Core::MAX]; @@ -83,11 +82,11 @@ extern TextStream dout[Core::MAX]; * an array in the multi core case, which consists of three TextStreams and * one CopyStream. * For that, construction is done like: + * \todo(11) Define `copyout` * * \code{.cpp} * OutputStream* copyout[Core::MAX]{&dout[0], &dout[1], ...} * \endcode * - * \todo(11) Define `copyout` */ extern OutputStream* copyout[Core::MAX]; diff --git a/device/serialstream.h b/device/serialstream.h index d1708ff..c3afc51 100644 --- a/device/serialstream.h +++ b/device/serialstream.h @@ -61,7 +61,6 @@ class SerialStream : public OutputStream, public Serial { * * Sets up the serial connection as well * - * \todo(11) Implement Method */ explicit SerialStream(ComPort port = COM1, BaudRate baud_rate = BAUD_115200, DataBits data_bits = DATA_8BIT, @@ -74,13 +73,11 @@ class SerialStream : public OutputStream, public Serial { * The method is automatically called when the buffer is full, * but can also be called explicitly to force output of the current buffer. * - * \todo(11) Implement Method */ void flush() override; /*! \brief Change foreground color (for subsequent output) * - * \todo(11) Implement Method * * \param c Color */ @@ -88,7 +85,6 @@ class SerialStream : public OutputStream, public Serial { /*! \brief Change background color (for subsequent output) * - * \todo(11) Implement Method * * \param c Color */ @@ -96,7 +92,6 @@ class SerialStream : public OutputStream, public Serial { /*! \brief Change text attribute (for subsequent output) * - * \todo(11) Implement Method * * \param a Attribute */ @@ -107,7 +102,6 @@ class SerialStream : public OutputStream, public Serial { * Clear screen, place cursor at the beginning and reset colors * and attributes to the default value. * - * \todo(11) Implement Method */ void reset(); @@ -116,7 +110,6 @@ class SerialStream : public OutputStream, public Serial { * \param x Column in window * \param y Row in window * - * \todo(11) Implement Method */ void setPos(int x, int y); diff --git a/device/textstream.h b/device/textstream.h index f8b7eac..561f9b3 100644 --- a/device/textstream.h +++ b/device/textstream.h @@ -36,7 +36,6 @@ class TextStream: public OutputStream, protected TextWindow { * but can also be called explicitly to force output of the current buffer. * * - * \todo(11) Implement method */ void flush(); diff --git a/object/stringbuffer.h b/object/stringbuffer.h index 8619a6e..6e394c6 100644 --- a/object/stringbuffer.h +++ b/object/stringbuffer.h @@ -52,7 +52,6 @@ class Stringbuffer { * * \param c Char to be added * - * \todo(11) Implement */ void put(char c);