arch/serial.cc

@@ -1,23 +1,18 @@
 #include "serial.h"
-#include "ioport.h"
 
 Serial::Serial(ComPort port, BaudRate baud_rate, DataBits data_bits,
                StopBits stop_bits, Parity parity)
     : port(port) {
   // initialize FIFO mode, no irqs for sending, irq if first byte was received
-  writeReg(INTERRUPT_ENABLE_REGISTER, RECEIVED_DATA_AVAILABLE);
 
   // line control, select r/w of divisor latch register
   writeReg(LINE_CONTROL_REGISTER, DIVISOR_LATCH_ACCESS_BIT);
 
-  writeReg(DIVISOR_LOW_REGISTER, baud_rate & 0xFF);
+  // TODO: Implement here the correct handling of input arguments
-  writeReg(DIVISOR_HIGH_REGISTER, (baud_rate>>8) & 0xFF);
+  (void)baud_rate;
-
+  (void)data_bits;
-  // also turns DLAB off
+  (void)stop_bits;
-  uint8_t val = parity;
+  (void)parity;
-  val |= stop_bits;
-  val |= data_bits;
-  writeReg(LINE_CONTROL_REGISTER, val);
 
   // FIFO: Enable & clear buffers
   writeReg(FIFO_CONTROL_REGISTER,
@@ -28,22 +23,19 @@ Serial::Serial(ComPort port, BaudRate baud_rate, DataBits data_bits,
 }
 
 void Serial::writeReg(RegisterIndex reg, char out) {
-  uint16_t addr = port;
+  // TODO: Implement
-  IOPort iop = IOPort(addr += reg);
+  (void)reg;
-  iop.outb(out);
+  (void)out;
 }
 
 char Serial::readReg(RegisterIndex reg) {
-  uint16_t addr = port;
+  // TODO: Implement
-  IOPort iop = IOPort(addr += reg);
+  (void)reg;
-  return iop.inb();
+  return '\0';
 }
 
 int Serial::write(char out) {
   // TODO: Implement
-  if(readReg(LINE_STATUS_REGISTER) & TRANSMITTER_EMPTY){
+  (void)out;
-      writeReg(TRANSMIT_BUFFER_REGISTER, out);
+  return 0;
-      return out;
-  }
-  return -1;
 }

arch/textwindow.cc

@@ -20,15 +20,9 @@ void TextWindow::setPos(unsigned rel_x, unsigned rel_y) {
 }
 
 void TextWindow::getPos(unsigned& rel_x, unsigned& rel_y) const {
-    if(use_cursor){
         CGA::getCursor(rel_x, rel_y);
         rel_x -= from_col;
         rel_y -= from_row;
-    }
-    else {
-        rel_x = pos_x - from_col;
-        rel_y = pos_y - from_row;
-    }
 }
 
 void TextWindow::setPos(int rel_x, int rel_y) {
@@ -41,10 +35,8 @@ void TextWindow::setPos(int rel_x, int rel_y) {
 }
 
 void TextWindow::getPos(int& rel_x, int& rel_y) const {
-    unsigned x, y;
+  (void)rel_x;
-    getPos(x,y);
+  (void)rel_y;
-    rel_x = x;
-    rel_y = y;
 }
 
 void TextWindow::print(const char* str, size_t length, CGA::Attribute attrib) {
@@ -55,7 +47,7 @@ void TextWindow::print(const char* str, size_t length, CGA::Attribute attrib) {
         if(from_col+x_now >= to_col-1){
             x_now = 0;
             if(from_row + y_now >= to_row-1){
-                //TODO scrollUp()
+                //scrollUp()
             }
             else{
                 y_now++;

arch/textwindow.h

@@ -55,6 +55,7 @@ class TextWindow {
    *                   software cursor/variable (`false`) should be used to
    *                   store the current position
    *
+   *  \todo(11) Implement constructor
    */
   TextWindow(unsigned from_col, unsigned to_col, unsigned from_row,
              unsigned to_row, bool use_cursor = false);
@@ -70,6 +71,8 @@ class TextWindow {
    *
    *  \param rel_x Column in window
    *  \param rel_y Row in window
+   *  \todo(11) Implement method, use \ref CGA::setCursor() for the hardware
+   * cursor
    */
   void setPos(unsigned rel_x, unsigned rel_y);
 
@@ -84,6 +87,8 @@ class TextWindow {
    * Negative coordinates are interpreted relative to the right and bottom
    * border of the window.
    *
+   *  \todo(11) Implement this method (it can either use or replace
+   *       \ref setPos(unsigned, unsigned))
    */
   void setPos(int rel_x, int rel_y);
 
@@ -95,6 +100,8 @@ class TextWindow {
    *
    *  \param rel_x Column in window
    *  \param rel_y Row in window
+   *  \todo(11) Implement Method, use \ref CGA::getCursor() for the hardware
+   * cursor
    */
   void getPos(unsigned& rel_x, unsigned& rel_y) const;
 
@@ -121,6 +128,7 @@ class TextWindow {
    *  \param string Text to be printed
    *  \param length Length of text
    *  \param attrib Attribute for text
+   *  \todo(11) Implement Method
    */
   void print(const char* string, size_t length,
              CGA::Attribute attrib = CGA::Attribute());  // NOLINT
@@ -129,6 +137,7 @@ class TextWindow {
    *
    *  \param character Fill character
    *  \param attrib Attribute for fill character
+   *  \todo(11) Implement Method
    */
   void reset(char character = ' ', CGA::Attribute attrib = CGA::Attribute());
 };

device/serialstream.cc

@@ -1,95 +1,30 @@
 #include "serialstream.h"
-#include "../utils/string.h"
 
 SerialStream::SerialStream(ComPort port, BaudRate baud_rate, DataBits data_bits,
-                           StopBits stop_bits, Parity parity)
+                           StopBits stop_bits, Parity parity) {
-    :Serial(port, baud_rate, data_bits, stop_bits, parity) {}
+  (void)port;
-
+  (void)baud_rate;
-void SerialStream::flush() {
+  (void)data_bits;
-  print(buffer, strlen(buffer));
+  (void)stop_bits;
+  (void)parity;
 }
 
-// https://stackoverflow.com/questions/3440726/what-is-the-proper-way-of-implementing-a-good-itoa-function
+void SerialStream::flush() {}
-// Yet, another good itoa implementation
-// returns: the length of the number string
-int itoa(int value, char *sp, int radix)
-{
-    char tmp[16];// be careful with the length of the buffer
-    char *tp = tmp;
-    int i;
-    unsigned v;
-
-    int sign = (radix == 10 && value < 0);    
-    if (sign)
-        v = -value;
-    else
-        v = (unsigned)value;
-
-    while (v || tp == tmp)
-    {
-        i = v % radix;
-        v /= radix;
-        if (i < 10)
-          *tp++ = i+'0';
-        else
-          *tp++ = i + 'a' - 10;
-    }
-
-    int len = tp - tmp;
-
-    if (sign) 
-    {
-        *sp++ = '-';
-        len++;
-    }
-
-    while (tp > tmp)
-        *sp++ = *--tp;
 
-    return len;
+void SerialStream::setForeground(Color c) { (void)c; }
-}
-
-void SerialStream::setForeground(Color c) {
-    write(0x1b);
-    write('[');
-    write('3');
-    write(c + 0x30);
-    write('m');
-}
 
-void SerialStream::setBackground(Color c) { 
+void SerialStream::setBackground(Color c) { (void)c; }
-    write(0x1b);
-    write('[');
-    write('4');
-    write(c + 0x30);
-    write('m');
-}
 
-void SerialStream::setAttribute(Attrib a) {
+void SerialStream::setAttribute(Attrib a) { (void)a; }
-    write(0x1b);
-    write('[');
-    write(a + 0x30);
-    write('m');
-}
 
-void SerialStream::reset() {
+void SerialStream::reset() {}
-    write(0x1b);
-    write('c');
-}
 
 void SerialStream::setPos(int x, int y) {
-    //char out[] = {0x1b, '[', 0, 0, ';', 0, 0, 'H', 0};
+  (void)x;
-    *this << 0x1b;
+  (void)y;
-    *this << '[';
-    *this << dec << x;
-    *this << ';' << y << 'H' << endl;
-    flush();
-    //itoa(x, &out[2], 10);
-    //itoa(y, &out[5], 10);
-    //print( out , strlen(out));
 }
 
 void SerialStream::print(char* str, int length) {
-    for(int i=0; i < length; i++)
+  (void)str;
-        write(str[i]);
+  (void)length;
 }

device/textstream.cc

@@ -1,21 +1,12 @@
 #include "textstream.h"
 
-TextStream::TextStream(unsigned from_col, 
+TextStream::TextStream(unsigned from_col, unsigned to_col, unsigned from_row,
-                       unsigned to_col, 
+                       unsigned to_row, bool use_cursor) {
-                       unsigned from_row,
+  (void)from_col;
-                       unsigned to_row, 
+  (void)to_col;
-                       bool use_cursor)
+  (void)from_row;
-          : TextWindow(from_col,
+  (void)to_row;
-            to_col,
+  (void)use_cursor;
-            from_row,
-            to_row,
-            use_cursor){}
-
-
-void TextStream::flush() {
-  print(buffer,pos);
-  pos = 0;
-  
-
-
 }
+
+void TextStream::flush() {}

device/textstream.h

@@ -8,8 +8,7 @@
 
 #pragma once
 #include "../types.h"
-#include "../object/outputstream.h"
+
-#include "../arch/textwindow.h"
 /*! \brief  Output text (form different data type sources) on screen in text
  * mode
  *  \ingroup io
@@ -20,7 +19,7 @@
  * \ref TextWindow and only implements the method \ref TextStream::flush().
  * Further formatting or special effects are implemented in \ref TextWindow.
  */
-class TextStream: public OutputStream, protected TextWindow {
+class TextStream {
   // Prevent copies and assignments
   TextStream(const TextStream&) = delete;
   TextStream& operator=(const TextStream&) = delete;
@@ -39,11 +38,4 @@ class TextStream: public OutputStream, protected TextWindow {
    *  \todo(11) Implement method
    */
   void flush();
-
- private:
-      unsigned from_col;
-      unsigned to_col;
-      unsigned from_row;
-      unsigned to_row;
-      bool use_cursor;
 };

main.cc

@@ -4,8 +4,6 @@
 
 #include "arch/cga.h"
 #include "arch/textwindow.h"
-#include "arch/serial.h"
-#include "device/serialstream.h"
 
 // Main function
 // (the bootstrap processor starts here)}
@@ -21,35 +19,14 @@ extern "C" int main() {
   //for(uint8_t i = 0; i < 10; i++)
   //  CGA::show(i, i, i+0x30, CGA::Attribute());
 
-  ////test textwindow implemantation
+  //test textwindow implemantation
-  //TextWindow tw_global = TextWindow(0, 80, 0, 25, true);
+  TextWindow tw_global = TextWindow(0, 80, 0, 25, true);
-  //tw_global.reset(' ', CGA::Attribute(CGA::LIGHT_GREEN, CGA::BLUE, false));
+  tw_global.reset(' ', CGA::Attribute(CGA::LIGHT_GREEN, CGA::BLUE, false));
-  //TextWindow tw = TextWindow(0, 10, 0, 10, true);
-  //tw.reset();
-  //tw.setPos(0,0);
-  //tw.print("lorem ipsum dolor sit amit", 26);
-  //tw.setPos(0,-1);
-  //tw.print("test", 4, CGA::Attribute(CGA::BLACK, CGA::BLUE));
-  //int x,y;
-  //tw.getPos(x,y);
-  //tw.setPos(x+1,y);
 
-  ////test Serial
+  TextWindow tw = TextWindow(0, 10, 0, 10, true);
-  //Serial s = Serial();
+  tw.reset();
-  //s.write('a');
+  tw.setPos(0,0);
-
+  tw.print("lorem ipsum dolor sit amit", 26);
-  // test SerialStream
-  SerialStream ss = SerialStream();
-  ss.print("test", 4);
-  ss.setAttribute(SerialStream::UNDERSCORE);
-  ss.print("test", 4);
-  ss.setAttribute(SerialStream::RESET);
-  ss.setForeground(SerialStream::MAGENTA);
-  ss.print("test", 4);
-  ss.setBackground(SerialStream::CYAN);
-  ss.print("test", 4);
-  ss.setPos(10, 10);
-  ss.print("test", 4);
 
   /* Start application processors
    * To avoid unexpected behaviour, make sure that interrupts are not

object/stringbuffer.h

@@ -43,7 +43,7 @@ class Stringbuffer {
  protected:
   /*! \brief Constructor; Marks the buffer as empty
    */
-  Stringbuffer() : pos(0){}
+  Stringbuffer() {}
 
   /*! \brief Inserts a character into the buffer.
    *
@@ -64,8 +64,6 @@ class Stringbuffer {
    */
   virtual void flush() = 0;
 
-  unsigned pos;
-  char buffer[80+1]; 
  public:
   /*! \brief Destructor (nothing to do here)
    */

tools/qemu.mk

@@ -59,7 +59,7 @@ kvm: all
 
 # Execute Qemu with activated GDB stub and directly connect GDB to the spawned Qemu.
 gdb: all
-	${VERBOSE}  $(GDB) "$(DBGKERNEL)" \
+	${VERBOSE} cgdb -d $(GDB) "$(DBGKERNEL)" \
 		-ex "set arch $(DBGARCH)" \
 		-ex "target remote | exec $(QEMU) -gdb stdio $(QEMUKERNEL) -smp $(QEMUCPUS) -S $(QEMUFLAGS) $(DBGFLAGS)"